Skip to content

Skip execution of Julia startup file when checking for envdir#561

Open
sorokod wants to merge 1 commit into
JuliaEditorSupport:masterfrom
sorokod:Skip-execution-of-startup-file-when-checking-for-Julia-envdir
Open

Skip execution of Julia startup file when checking for envdir#561
sorokod wants to merge 1 commit into
JuliaEditorSupport:masterfrom
sorokod:Skip-execution-of-startup-file-when-checking-for-Julia-envdir

Conversation

@sorokod

@sorokod sorokod commented Mar 28, 2021

Copy link
Copy Markdown

The change to getEnvDir() is implemented using a non interactive call to Julia ( -E ) and required a change for executeCommand to accept multiple arguments.

@sorokod sorokod changed the title Skip execution of startup file when checking for Julia envdir Skip execution of Julia startup file when checking for Julia envdir Mar 28, 2021
@sorokod sorokod changed the title Skip execution of Julia startup file when checking for Julia envdir Skip execution of Julia startup file when checking for envdir Mar 28, 2021
@sorokod

sorokod commented Mar 28, 2021

Copy link
Copy Markdown
Author

I bumped my local Kotlin version to 1.4 to avoid the error here ...available since Kotlin 1.4 and cannot be used in Kotlin 1.3 but the error has nothing to do with a change in this PR.

@ice1000 , does master builds for you with 1.3 ?

@ice1000

ice1000 commented Mar 28, 2021

Copy link
Copy Markdown
Member

I bumped my local Kotlin version to 1.4 to avoid the error here ...available since Kotlin 1.4 and cannot be used in Kotlin 1.3 but the error has nothing to do with a change in this PR.

@ice1000 , does master builds for you with 1.3 ?

Idk, I haven't built this for a while

@ice1000

ice1000 commented Mar 28, 2021

Copy link
Copy Markdown
Member

This PR LGTM so far

@ice1000 ice1000 self-assigned this Mar 28, 2021
@ice1000 ice1000 requested a review from zxj5470 March 28, 2021 17:31
@sorokod

sorokod commented Mar 28, 2021

Copy link
Copy Markdown
Author

For whatever it's worth, my changes to the build

  kotlin("jvm") version "1.4.31"
  ...
  setPlugins("PsiViewer:211-SNAPSHOT", "java")
 ...
	kotlinOptions {
		jvmTarget = "1.8"
		languageVersion = "1.4"
		apiVersion = "1.4"
		...
	}


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants